Conversation
ejsmith
left a comment
There was a problem hiding this comment.
There is no reason to be creating and passing the resilience policy provider into any of these classes unless we are changing their behavior which I have no idea why we would. Even if we use the resilience policy ourselves in Exceptionless, you still don't need to be passing it into any of the foundatio classes unless we are changing the behavior.
| Topic = options.Topic, | ||
| Serializer = s.GetRequiredService<ISerializer>(), | ||
| TimeProvider = s.GetRequiredService<TimeProvider>(), | ||
| ResiliencePolicyProvider = s.GetRequiredService<IResiliencePolicyProvider>(), |
There was a problem hiding this comment.
You should not be passing this in unless you plan to change the default behavior.
| Topic = options.Topic, | ||
| Serializer = s.GetRequiredService<ISerializer>(), | ||
| TimeProvider = s.GetRequiredService<TimeProvider>(), | ||
| ResiliencePolicyProvider = s.GetRequiredService<IResiliencePolicyProvider>(), |
There was a problem hiding this comment.
You should not be passing this in unless you plan to change the default behavior.
| ContainerName = $"{options.ScopePrefix}ex-events", | ||
| Serializer = s.GetRequiredService<ITextSerializer>(), | ||
| TimeProvider = s.GetRequiredService<TimeProvider>(), | ||
| ResiliencePolicyProvider = s.GetRequiredService<IResiliencePolicyProvider>(), |
There was a problem hiding this comment.
You should not be passing this in unless you plan to change the default behavior.
| ConnectionString = options.ConnectionString, | ||
| Serializer = s.GetRequiredService<ITextSerializer>(), | ||
| TimeProvider = s.GetRequiredService<TimeProvider>(), | ||
| ResiliencePolicyProvider = s.GetRequiredService<IResiliencePolicyProvider>(), |
There was a problem hiding this comment.
You should not be passing this in unless you plan to change the default behavior.
| Folder = PathHelper.ExpandPath(path), | ||
| Serializer = s.GetRequiredService<ITextSerializer>(), | ||
| TimeProvider = s.GetRequiredService<TimeProvider>(), | ||
| ResiliencePolicyProvider = s.GetRequiredService<IResiliencePolicyProvider>(), |
There was a problem hiding this comment.
You should not be passing this in unless you plan to change the default behavior.
| WorkItemTimeout = workItemTimeout.GetValueOrDefault(TimeSpan.FromMinutes(5.0)), | ||
| Serializer = container.GetRequiredService<ISerializer>(), | ||
| TimeProvider = container.GetRequiredService<TimeProvider>(), | ||
| ResiliencePolicyProvider = container.GetRequiredService<IResiliencePolicyProvider>(), |
There was a problem hiding this comment.
You should not be passing this in unless you plan to change the default behavior.
| RunMaintenanceTasks = runMaintenanceTasks, | ||
| Serializer = container.GetRequiredService<ISerializer>(), | ||
| TimeProvider = container.GetRequiredService<TimeProvider>(), | ||
| ResiliencePolicyProvider = container.GetRequiredService<IResiliencePolicyProvider>(), |
There was a problem hiding this comment.
You should not be passing this in unless you plan to change the default behavior.
| ConnectionMultiplexer = container.GetRequiredService<IConnectionMultiplexer>(), | ||
| Serializer = container.GetRequiredService<ISerializer>(), | ||
| TimeProvider = container.GetRequiredService<TimeProvider>(), | ||
| ResiliencePolicyProvider = container.GetRequiredService<IResiliencePolicyProvider>(), |
There was a problem hiding this comment.
You should not be passing this in unless you plan to change the default behavior.
| WorkItemTimeout = workItemTimeout.GetValueOrDefault(TimeSpan.FromMinutes(5.0)), | ||
| Serializer = container.GetRequiredService<ISerializer>(), | ||
| TimeProvider = container.GetRequiredService<TimeProvider>(), | ||
| ResiliencePolicyProvider = container.GetRequiredService<IResiliencePolicyProvider>(), |
There was a problem hiding this comment.
You should not be passing this in unless you plan to change the default behavior.
| { | ||
| Serializer = s.GetRequiredService<ITextSerializer>(), | ||
| TimeProvider = s.GetRequiredService<TimeProvider>(), | ||
| ResiliencePolicyProvider = s.GetRequiredService<IResiliencePolicyProvider>(), |
There was a problem hiding this comment.
You should not be passing this in unless you plan to change the default behavior.
Updates Foundatio packages to version 12.0.0 across multiple projects. This ensures the application uses the latest features, bug fixes, and improvements available in the Foundatio libraries.
Updates the Foundatio.Xunit package to the latest stable version.
Refactors the `WaitForReadyAsync` extension method to no longer rely on the `ProxyTimeProvider`. This simplifies the method signature and removes an unnecessary dependency. The test server now relies on the standard `Task.Delay` method.
Removes the need for TimeProvider in TaskExtensions.WaitAsync and updates related test calls. This simplifies the test code and relies on the default Task.Delay implementation.
|
No description provided.