Fix: Sheet Properties Types #2327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Sheet Properties Types
Contributor
Author
|
@Siemienik please consider reviewing the PR and release ASAP as it breaks our code and requires using "any" type which is not correct |
Contributor
|
@albeniraouf Could you please move over here? I'd be happy to merge this feature. |
Member
|
Thank you @albeniraouf. that's good patch 👍 |
This was referenced Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Related to source code (for typings update)
exceljs/spec/unit/xlsx/xform/sheet/sheet-properties-xform.spec.js
Line 43 in eec76a1
exceljs/lib/stream/xlsx/worksheet-writer.js
Line 532 in eec76a1
exceljs/lib/xlsx/xform/sheet/worksheet-xform.js
Line 302 in eec76a1