This repository was archived by the owner on Apr 4, 2024. It is now read-only.
Problem: No way to limit total number of filters that can be created #661
+54
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Add a config parameter to set the total number of filters that can be created
Codecov Report
@@ Coverage Diff @@
## main #661 +/- ##
==========================================
- Coverage 57.03% 57.00% -0.04%
==========================================
Files 63 63
Lines 5535 5540 +5
==========================================
+ Hits 3157 3158 +1
- Misses 2215 2219 +4
Partials 163 163
|
tomtau
reviewed
Oct 12, 2021
Contributor
tomtau
left a comment
There was a problem hiding this comment.
looks ok -- just a small nit on the current locking
fedekunze
reviewed
Oct 12, 2021
Collaborator
fedekunze
left a comment
There was a problem hiding this comment.
LGTM, can you add a Changelog entry too?
devashishdxt
commented
Oct 13, 2021
Author
Done |
fedekunze
reviewed
Oct 13, 2021
fedekunze
approved these changes
Oct 13, 2021
Collaborator
|
@devashishdxt can you fix the linter issues? |
auto-merge was automatically disabled
October 13, 2021 09:54
Head branch was pushed to by a user without write access
Author
Done |
thomas-nguy
referenced
this pull request
in crypto-org-chain/ethermint
Oct 26, 2021
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Add a config parameter to set the total number of filters that can be created
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)