Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

replace tm internal websocket with long poll#1321

Closed
mmsqe wants to merge 24 commits intoevmos:mainfrom
mmsqe:long-poll
Closed

replace tm internal websocket with long poll#1321
mmsqe wants to merge 24 commits intoevmos:mainfrom
mmsqe:long-poll

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Sep 1, 2022

Closes: crypto-org-chain/cronos#665

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

before tm support default "newest" cursor
before tm support waitscan by newest cursor with specific query
@mmsqe mmsqe force-pushed the long-poll branch 4 times, most recently from a2eed86 to c893147 Compare September 5, 2022 07:10
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1321 (4678852) into main (1a5b64d) will increase coverage by 1.36%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
+ Coverage   55.16%   56.53%   +1.36%     
==========================================
  Files         105      105              
  Lines        9608     9609       +1     
==========================================
+ Hits         5300     5432     +132     
+ Misses       4043     3912     -131     
  Partials      265      265              
Impacted Files Coverage Δ
rpc/backend/call_tx.go 0.00% <0.00%> (ø)
rpc/backend/account_info.go 0.00% <0.00%> (ø)
rpc/backend/blocks_info.go
rpc/backend/blocks.go 87.76% <0.00%> (ø)

defaultFilter := coretypes.EventFilter{Query: ""}
defaultMaxItems := 1
if sub.after == defaultAfter {
res, resErr := es.client.Events(ctx, &coretypes.RequestEvents{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally job could be done within single call when tm support extra earliest or latest param like kafka on 1st call.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

@fedekunze fedekunze added pinned Pinned issues that won't be closed by stalebot and removed Status: Stale labels Oct 26, 2022
@fedekunze
Copy link
Contributor

@mmsqe closing this PR as it doesn't seem to be finished and it's been accumulated conflicts. Feel free to open a new PR against main

@fedekunze fedekunze closed this Dec 11, 2022
@mmsqe
Copy link
Contributor Author

mmsqe commented Dec 11, 2022

@mmsqe closing this PR as it doesn't seem to be finished and it's been accumulated conflicts. Feel free to open a new PR against main

Got it, will try after this tendermint/tendermint#9857 get update

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pinned Pinned issues that won't be closed by stalebot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem: filter api missing events when internal websocket client reconnect

2 participants