This repository was archived by the owner on Apr 4, 2024. It is now read-only.
tests(rpc): add backend blocks tests #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
+ Coverage 55.16% 56.53% +1.36%
==========================================
Files 105 105
Lines 9608 9609 +1
==========================================
+ Hits 5300 5432 +132
+ Misses 4043 3912 -131
Partials 265 265
|
…his endpoint is breaking when querying a block with transactions
9 tasks
9 tasks
danburck
commented
Sep 1, 2022
facs95
suggested changes
Sep 1, 2022
Contributor
Author
|
@facs95 I addressed all the changes as we discussed in a call. Will merge now |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1248
Description
This PR adds unit test coverage for the backend
blocks.go. It also improves the method names to better represent their function. The unit tests use mocks for client and JSON-RPC clientNote
I noticed, that the method
EthBlockFromTendermintBlockhas an open todo to add receipts to the block. Currently this endpoint is not used much, so this should be dealt with in a different PR.