Skip to content

Fix "chosen" select box rendering in Firefox#1486

Merged
glensc merged 1 commit intoeventum:masterfrom
inguin:chosen-firefox
Jan 24, 2023
Merged

Fix "chosen" select box rendering in Firefox#1486
glensc merged 1 commit intoeventum:masterfrom
inguin:chosen-firefox

Conversation

@inguin
Copy link
Copy Markdown
Contributor

@inguin inguin commented Jan 23, 2023

Select boxes enriched with jquery-chosen are not properly rendered in Firefox: The dropdown is permanently visible (albeit initially empty), even if the select box is closed.

The issue seems to be caused by custom CSS rules which date back to a time when the plugin worked differently.

Select boxes enriched with jquery-chosen are not properly rendered in
Firefox: The dropdown is permanently visible (albeit initially empty),
even if the select box is closed.

The issue seems to be caused by custom CSS rules which date back to
a time when the plugin worked differently.
@glensc
Copy link
Copy Markdown
Member

glensc commented Jan 23, 2023

Screenshots?

@glensc glensc added this to the 3.10.13 milestone Jan 23, 2023
@inguin
Copy link
Copy Markdown
Contributor Author

inguin commented Jan 23, 2023

eventum-chosen

Would you prefer a proper bug report?

@glensc
Copy link
Copy Markdown
Member

glensc commented Jan 23, 2023

And this will continue to work on Chrome?

@inguin
Copy link
Copy Markdown
Contributor Author

inguin commented Jan 23, 2023

And this will continue to work on Chrome?

Yes. So far I've tested Firefox, Chrome and Chromium.

Generally I'd assume that the jquery-chosen plugin has pretty good browser compatibility by default. Can you recall what prompted the addition of those custom rules back in 2015?

@glensc
Copy link
Copy Markdown
Member

glensc commented Jan 24, 2023

I suppose you ran git blame and found commits for those changes (why not share them?). your guess is as good as mine. I only know I'm not a CSS guru, so the CSS was likely provided by somebody else

the position: relative came from initial integration:

height: 27px and top: 0 came from:

@inguin
Copy link
Copy Markdown
Contributor Author

inguin commented Jan 24, 2023

I only know I'm not a CSS guru

Neither am I. I only saw that the jQuery Chosen demo page works flawlessly in all my browsers, so I disabled Eventum's custom CSS rules one by one until it looked fine there as well.

The Chosen plugin was upgraded from 1.2.0 to 1.8.7 in #812, so my best guess is that whatever the rules were supposed to fix has also been addressed in the original project by now.

@glensc glensc merged commit 48bec9a into eventum:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants