Fix: Drop "replace" keys from composer.json#1291
Merged
glensc merged 11 commits intoeventum:masterfrom Dec 12, 2021
Merged
Conversation
53f392d to
04776af
Compare
No sub-module is needed for building the release
Using replace is nice way to minimize vendor size, but it also makes it very difficult to install dependencies when eventun/eventum is being used as "packages-dev" The major obstacle is that "replace" may be provided by only one package the way composer thinks. The "replace" works fine when used as project, but we also want to use eventum as library, for example extension development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using replace is nice way to minimize vendor size,
but it also makes it very difficult to install dependencies
when eventum/eventum is being used as "packages-dev"
The major obstacle is that "replace" may be provided by only one package
the way composer thinks.
The "replace" works fine when used as project, but we also want to use
eventum as library, for example extension development
NOTE: this removes "replace" key from committed version, but still uses it as release process.