Skip to content

Feature: Use ServiceContainer first when finding classes for extensions#1290

Merged
glensc merged 2 commits intoeventum:masterfrom
glensc:ext-lookup
Dec 12, 2021
Merged

Feature: Use ServiceContainer first when finding classes for extensions#1290
glensc merged 2 commits intoeventum:masterfrom
glensc:ext-lookup

Conversation

@glensc
Copy link
Copy Markdown
Member

@glensc glensc commented Dec 12, 2021 •
edited
Loading

This allows clean up extensions needing to provide factory method that just do lookup from container:

    public function factory($className)
    {
        $services = self::getServiceContainer();

        if (isset($services[$className])) {
            return $services[$className];
        }

        return null;
    }

@glensc glensc added this to the 3.10.10 milestone Dec 12, 2021
@glensc glensc self-assigned this Dec 12, 2021
@glensc glensc merged commit ff9a8ef into eventum:master Dec 12, 2021
@glensc glensc deleted the ext-lookup branch December 12, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@glensc glensc

Labels

None yet

Milestone

3.10.10

Development

Successfully merging this pull request may close these issues.

1 participant

@glensc