LdapSyncCommand: disable users missing in LDAP Active DN#1221
Merged
glensc merged 5 commits intoeventum:masterfrom Oct 3, 2021
Merged
LdapSyncCommand: disable users missing in LDAP Active DN#1221glensc merged 5 commits intoeventum:masterfrom
glensc merged 5 commits intoeventum:masterfrom
Conversation
Member
|
please avoid those click-bait titles, unable to understand what the changeset is just by looking the title. so one must click on the diffs to get even a grasp of the proposed changes |
Closed
Contributor
Author
|
@glensc Shall I expect this PR to be accepted? |
Member
|
@vladsf there's no email notification once you mark PR ready for review, so you need to ask implicitly once it's ready, or just wait |
Member
|
I don't understand the PR title nor changelog entry what this PR does. please improve. what is users missed or missed users? |
glensc
reviewed
Oct 1, 2021
glensc
reviewed
Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LdapSyncCommand lacks an option to search and disable Eventum users which are not found in LDAP Active DN. Current code expects to find inactive users in Inactive DN.
This patch proposes --disable-missed option to check active Eventum users against LDAP. Users which are not found in Active DN to be set inactive.