Skip to content

Make user notification on account creation optional#1210

Merged
glensc merged 4 commits intoeventum:masterfrom
vladsf:donotsendnotice
Sep 25, 2021
Merged

Make user notification on account creation optional#1210
glensc merged 4 commits intoeventum:masterfrom
vladsf:donotsendnotice

Conversation

@vladsf
Copy link
Copy Markdown
Contributor

@vladsf vladsf commented Sep 24, 2021

Do not send email notice if user password is not set.
If user accounts are created outside Eventum e.g. in LDAP and then ldapsync'ed then there is no reason to send email notice with
empty password.

@glensc
Copy link
Copy Markdown
Member

glensc commented Sep 24, 2021

if my users are external, none of them have passwords set in the eventum database (because they are external). why would I want disable all of their notifications?

if you want this feature, you need to make it configurable (enable notifications perhaps?).

also, add a changelog entry

@glensc glensc added this to the 3.10.7 milestone Sep 24, 2021
@vladsf vladsf changed the title Do not send notification email if user password is not set WIP: Do not send notification email if user password is not set Sep 24, 2021
@vladsf
Copy link
Copy Markdown
Contributor Author

vladsf commented Sep 24, 2021

OK, refactored. I made notification email optional on user creation. The same way as User::update() does on account sync updates in LdapAdapter.php

This change does not affect current workflow and only repeats User::update() call.

This allows to call User::insert() with disabled notification from LdapAdapter.php later.

@vladsf vladsf changed the title WIP: Do not send notification email if user password is not set WIP: Make user notification on account creation optional Sep 24, 2021
@vladsf vladsf changed the title WIP: Make user notification on account creation optional Make user notification on account creation optional Sep 24, 2021
@glensc
Copy link
Copy Markdown
Member

glensc commented Sep 25, 2021

please rebase against origin/master, rather create merge commit in merge request.

but I'll squash merge this time. consider this if you want to preserve your original commit messages after merge.

@glensc glensc merged commit f51cf94 into eventum:master Sep 25, 2021
@vladsf vladsf deleted the donotsendnotice branch September 25, 2021 09:07
@vladsf
Copy link
Copy Markdown
Contributor Author

vladsf commented Sep 25, 2021

Ack. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants