Make user notification on account creation optional#1210
Make user notification on account creation optional#1210glensc merged 4 commits intoeventum:masterfrom
Conversation
|
if my users are external, none of them have passwords set in the eventum database (because they are external). why would I want disable all of their notifications? if you want this feature, you need to make it configurable (enable notifications perhaps?). also, add a changelog entry |
|
OK, refactored. I made notification email optional on user creation. The same way as This change does not affect current workflow and only repeats This allows to call User::insert() with disabled notification from LdapAdapter.php later. |
|
please rebase against origin/master, rather create merge commit in merge request. but I'll squash merge this time. consider this if you want to preserve your original commit messages after merge. |
|
Ack. Thanks! |
Do not send email notice if user password is not set.
If user accounts are created outside Eventum e.g. in LDAP and then ldapsync'ed then there is no reason to send email notice with
empty password.