Add back 3.7 support#848
Merged
Merged
Conversation
Closed
itamarst
commented
Dec 18, 2023
| write=True, | ||
| timeout=self.gettimeout(), | ||
| timeout_exc=timeout_exc('timed out')) | ||
| elif _is_py_3_7 and "unexpected eof" in exc.args[1]: |
Contributor
Author
There was a problem hiding this comment.
The error code is 1 in this case, which is Not Helpful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #848 +/- ##
=====================================
Coverage 53% 53%
=====================================
Files 88 88
Lines 9862 9867 +5
Branches 1845 1847 +2
=====================================
+ Hits 5320 5323 +3
+ Misses 4157 4156 -1
- Partials 385 388 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
itamarst
commented
Dec 18, 2023
| eventlet_test_ipv6 = 1 | ||
| deps = | ||
| coverage==7.3.3 | ||
| coverage |
Contributor
Author
There was a problem hiding this comment.
Just use whichever version works with current Python version.
4383
requested changes
Dec 19, 2023
4383
left a comment
Member
There was a problem hiding this comment.
Please also remove https://github.com/eventlet/eventlet/blob/master/NEWS#L4
4383
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #846