Feat: Support JSON output to STDOUT#125
Merged
nateberkopec merged 1 commit intoevanphx:masterfrom Feb 14, 2023
Merged
Conversation
I want to support `benchmark-ips` in github-action-benchmark. https://github.com/benchmark-action/github-action-benchmark When it can write the result to STDOUT in JSON format, it would be easy to support it. This commits changes JSON output so that it can directly write to a given argument if it responds to `write`. It also adds tests and a section about JSON in README.
Contributor
|
I think this is fine, although I would like someone else to review. One note is becnhmarking on GitHub Actions and shared machines is probably most of the times not a good idea, because it's quite noisy. From that project's README, this seems very noisy indeed: https://benchmark-action.github.io/github-action-benchmark/dev/bench/ |
evanphx
approved these changes
Feb 6, 2023
kbrock
approved these changes
Feb 6, 2023
Contributor
There was a problem hiding this comment.
This looks nice.
Also, this feels like a big bug fix.
Not sure that this distinction matters, but just putting that out there.
Thank you @okuramasafumi
Contributor
Author
|
@eregon Although my primary motivation is to add |
Collaborator
|
Was busy with Puma last week, I'll get to releasing this now :) 大倉さんありがとうございます！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to support
benchmark-ipsin github-action-benchmark.https://github.com/benchmark-action/github-action-benchmark
When it can write the result to STDOUT in JSON format, it would be easy to support it.
This commits changes JSON output so that it can directly write to a given argument if it responds to
write.It also adds tests and a section about JSON in README.