Ensure to always run at least 1 iteration for both warmup and for measurement#121
Merged
nateberkopec merged 3 commits intoevanphx:masterfrom Jan 17, 2022
Merged
Conversation
* From about 80s to 35s.
…surement * Fixes evanphx#120 * Using do-while loops to ensure the loops run at least once.
cc1c169 to
10d86a4
Compare
10d86a4 to
7cd6884
Compare
Contributor
Author
|
I moved the CI to GitHub Actions since TravisCI no longer works. ruby-head fails probably due to too old rake, I'll just drop it for now to not add too many changes in this PR: https://github.com/eregon/benchmark-ips/runs/4840536252?check_suite_focus=true |
Contributor
Author
Collaborator
Wow, thank you so much for that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FloatDomainError: Infinityif warmup period is "small enough" #120Also: Reduce the time needed to runs the tests
cc @ivoanjo @nateberkopec