fork: moving fork handling from behind the experiment#255
Merged
eugeneo merged 1 commit intofork/11-can-tests-passfrom May 20, 2025
Merged
fork: moving fork handling from behind the experiment#255eugeneo merged 1 commit intofork/11-can-tests-passfrom
eugeneo merged 1 commit intofork/11-can-tests-passfrom
Conversation
- Moves fork handling from behind the event_engine_fork experiment
- No experiment (parity with original fork implementation):
- Thread pool and timer manager will go through the fork as expected
- Epoll poller fd will be recreated in the child
- EventHandles are closed in the child process.
- Behind experiment (new functionality):
- File descriptors are tracked in the collection
- FD generation is tracked and checked on every Posix call.
- AresResolver is reset on fork
- Fixes to address race between PosixEngine destructor and fork
handling.
- Thread pool will properly handle fork even if the parent PosixEngine
instance entered the destructor before the fork call
- Thread pool fork handler will wait for the parent event engine
destructor to finish before shutting down threads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handling.
instance entered the destructor before the fork call
destructor to finish before shutting down threads.