Clear sysattr cache if a null pointer is passed#255
Merged
bbonev merged 2 commits intoeudev-project:masterfrom Aug 21, 2023
Merged
Clear sysattr cache if a null pointer is passed#255bbonev merged 2 commits intoeudev-project:masterfrom
bbonev merged 2 commits intoeudev-project:masterfrom
Conversation
Collaborator
|
the indentation here is a mix of spaces and tabs (set tabstop to 2 to see the effect). what is it that requires this behavior? I don't see it documented in systemd |
Collaborator
|
oh, just saw the context. lgtm if the indentation is fixed. the code would likely benefit from a rebasing on top of upstream, or reforking |
Contributor
Author
|
Remove all tabs, but ... |
Collaborator
|
that's out of scope for this PR - don't worry. please squash the commits so that we don't have redundant commits. LGTM |
Member
|
@ArsenArsen you didn't click the review, I would assume it is good for a squashed merge, right? |
Collaborator
|
right |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #254