Fix problems detected by fortified builds#232
Merged
bbonev merged 10 commits intoeudev-project:masterfrom Jun 9, 2022
Merged
Conversation
This condition may happen with version as 3.2.12-pre1 which would generate udev-3.2.12-pre1 with length of 17 including the terminating 0, while struct udev_ctrl.version is only 16 bytes
In case of invalid input the resulting modalias would exceed the buffer and be truncated. Add checks to avoid generating truncated modalias.
ftruncate and lockf are declared with attribute ‘warn_unused_result’. Kill the warning and add a TODO comment.
Add a check to avoid creating files with path that may be truncated
ArsenArsen
approved these changes
Jun 9, 2022
ArsenArsen
requested changes
Jun 9, 2022
Collaborator
ArsenArsen
left a comment
There was a problem hiding this comment.
see above, I selected the wrong option by mistake.
Suggested-by: Arsen Arsenović <arsen@aarsen.me>
Suggested-by: Arsen Arsenović <arsen@aarsen.me>
- fix coding style while at it - add checks and fail in case lockf failed Suggested-by: Arsen Arsenović <arsen@aarsen.me>
lseek and ftruncate may fail; do not continue the processing if that happens Suggested-by: Arsen Arsenović <arsen@aarsen.me>
Also fix code style of sizeof() Suggested-by: Arsen Arsenović <arsen@aarsen.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested on gcc 11.3 with: