Merged
Conversation
While looking at our exit() invocations I noticed that the mtd_probe stuff uses 'exit(-1)' at various places, which is not really a good idea, as exit codes of processes on Linux are supposed to be in the range of 0…255. This patch cleans that up a bit, and fixes a number of other things: 1. Let's always let main() exit, nothing intermediary. We generally don't like code that invokes exit() on its own. 2. Close the file descriptors opened. 3. Some logging for errors is added, mostly on debug level. Please review this with extra care. As I don't have the right hardware to test this patch I only did superficial testing. systemd-commit: 41b9d436b2739cbe8bf9482b665d85d59d06bc0e Author: Lennart Poettering <lennart@poettering.net> Date: Tue Apr 24 17:50:01 2018 +0200
kaniini
approved these changes
Oct 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author: Lennart Poettering lennart@poettering.net
Date: Tue Apr 24 17:50:01 2018 +0200
systemd-commit: 41b9d436b2739cbe8bf9482b665d85d59d06bc0e