Refactor required fields check on Bulk CSV upload#59
Merged
aine-etke merged 1 commit intoetkecc:mainfrom Oct 17, 2024
jamazi:patch-1
Merged
Refactor required fields check on Bulk CSV upload#59aine-etke merged 1 commit intoetkecc:mainfrom jamazi:patch-1
aine-etke merged 1 commit intoetkecc:mainfrom
jamazi:patch-1
Conversation
Member
|
That issue already solved by #32 |
Member
|
let's consider it refactoring - the updated code looks way better, thank you for contribution! |
Contributor
Author
that fix didn't work, I just tried with the latest docker image. |
Member
|
That's odd... We confirmed it worked on multiple different servers, looks like it was broken again along the way, thank you for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix Awesome-Technologies/synapse-admin#552