Add support for issuing registration tokens when homeserver uses MAS#1067
Merged
Add support for issuing registration tokens when homeserver uses MAS#1067
Conversation
Based on cy1der's original implementation (cherry-picked), with the following improvements:
- Fix isMasInstance() to use endsWith() instead of includes() for stricter URL matching
- Replace per-call async resource detection with initRegistrationTokens() called once
at login and on module load (page refresh), patching resourceMap.registration_tokens
in place — removes await getResourceConfig() from every CRUD method
- Extract synapseRegistrationTokensResource as a named const to eliminate duplication
between the resourceMap default entry and the Synapse fallback path
- Add early returns in getRegistrationTokensResource() to reduce nesting
- Define proper discriminated union types (SynapseRegistrationTokensResourceType,
MASRegistrationTokensResourceType) replacing any usage
- Fix uses_allowed: 0 being treated as falsy by replacing || with ?? in MAS
create/update/convert handlers
… more deterministic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1055 by @cy1der
As the title suggests, this adds support for registration tokens with Matrix Authentication Service. Done by detecting that the OIDC provider is MAS and adapting the data provider accordingly, then converting the data to appear as a Synapse registration token to the front end, keeping this change entirely on back end.
Note: The length and pending count fields in the front end do not do anything when MAS is used as it does not need/provide those fields