Update for PureScript 0.15 #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tests pass: ❯ npx pulp@16.0.0-1 test
* Building project in /Users/trh/Desktop/purescript-freeap
Src Lib All
Warnings 0 0 0
Errors 0 0 0
* Build successful.
* Running tests...
valid case:
(Right Joe Smith 28)
empty last name:
(Left "Last name: Invalid NES")
invalid age:
(Left "Age: Invalid Int")
analyze:
(Right "BABABABABABABABABABAB")
stack safety:
(Right "safe for 100000 node")
laws:
Checking laws of FreeAp instances...
Checking 'Reflexivity' law for Eq
1000/1000 test(s) passed.
Checking 'Symmetry' law for Eq
1000/1000 test(s) passed.
Checking 'Transitivity' law for Eq
1000/1000 test(s) passed.
Checking 'Negation' law for Eq
1000/1000 test(s) passed.
Checking 'Identity' law for Functor
1000/1000 test(s) passed.
Checking 'Composition' law for Functor
1000/1000 test(s) passed.
Checking 'Associative composition' law for Apply
1000/1000 test(s) passed.
Checking 'Identity' law for Applicative
1000/1000 test(s) passed.
Checking 'Composition' law for Applicative
1000/1000 test(s) passed.
Checking 'Homomorphism' law for Applicative
1000/1000 test(s) passed.
Checking 'Interchange' law for Applicative
1000/1000 test(s) passed.
* Tests OK. |
Contributor
|
Bump! |
Owner
|
This looks great! Thanks so much for the PR. Much appreciated and apologies for the delay! |
Contributor
|
No problem! Thanks for taking care of the library 😄 |
Owner
|
Most welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ethul 👋
This PR updates
freeapfor PureScript 0.15, which supports ES modules in the FFI. Along the way I switched you from Travis CI to GitHub Actions as the Travis script isn't running anymore.As with previous compiler releases, I'm updating
freeapbecause Halogen depends on this library. If you'd like, I can help maintain this library strictly for compiler releases so you don't have to do anything each time we make a new one. If not, that's totally fine too!