Conversation
…nUpdate the Go toolchain to 1.23.4 and refresh all module dependencies\nto their latest compatible versions. This includes major updates to\nethkit, cobra, and other core libraries to ensure compatibility with\nthe latest Go version and to incorporate security fixes and new features.\n\nAlso add a new dependency on hashicorp/golang-lru/v2 for future caching\nfunctionality.\n\nThe update also includes improvements to the metadata service:\n- Add context timeouts to prevent hanging operations\n- Handle context cancellation gracefully during shutdown\n- Improve error handling and logging for sync status updates\n\nThese changes ensure the application remains secure, stable, and compatible\nwith the latest ecosystem changes while improving reliability of the\nmetadata service operations.
Savid
approved these changes
Sep 12, 2025
refactor: replace deprecated grpc.Dial with grpc.NewClient style: add missing nolint:errcheck comments on type assertions refactor: extract string literals into const keys to avoid typos chore: add empty lines for readability in metadata service test: replace hard-coded "test-id" with const testID
ci: update golangci-lint-action to v8.0.0 and simplify config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ethkitdependency from older version tov1.38.1, which includes a needed bump togo-ethereum(see here)ethpandaops/beaconStart()method. This would become invalid/canceled, causing all sync status updates to failcontext canceled: ethrpc: request fail: xxx