feat(server): Add Permanent Block Storage#36
Merged
Conversation
This commit addresses a potential integer overflow issue when converting int64 values to uint64 for 'slot' and 'epoch' fields in `DistinctBeaconBadBlockValues` and `DistinctBeaconBlockValues` functions. It also fixes a validation logic in the config to ensure that at least one agent configuration is provided.
This commit introduces a graceful shutdown mechanism for the permanent store, ensuring that all queued blocks are processed before the store is stopped. It also adds a stopped flag to prevent new blocks from being queued after the stop signal is received. Additionally, it increases the number of goroutines processing the queue to improve performance.
This commit renames the "*PermanentStoreBlock" components to "*BlockInfo" for clarity and consistency. This change affects the BeaconBadBlockInfo, BeaconBlockInfo, and ExecutionBadBlockInfo components, as well as their import and usage in the Info part.
fix(permanent_store.go): add retry mechanism for acquiring lock test(permanent_store_test.go): add process channel to test queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.