fix: kt run . without --args-file should run without error (#166)

samlaf · web-flow · commit d137619ec1e3 · 2025-03-11T21:15:00.000Z
Fix the defaults in input_parser and sanity_checker such that `kt run .` works without errors. Also added running `kt run .` without --args-file to per-pr ci file so that we can catch these errors early (for eg there was a bug in my previous altda default config such that it wasnt even getting picked up). I like this quote from https://chshersh.com/blog/2025-01-06-the-most-elegant-configuration-language.html <img width="813" alt="image" src="https://github.com/user-attachments/assets/6fef77f8-a58f-4dfa-b8d6-3c866ffc541c" />
diff --git a/.github/workflows/per-pr.yml b/.github/workflows/per-pr.yml
@@ -26,6 +26,23 @@ jobs:
       - name: Run Starlark
         run: kurtosis run ${{ github.workspace }} --args-file ${{ matrix.file_name }} --verbosity detailed
 
+  # Make sure that `kurtosis run .` without an --args-file works fine (the defaults in input_parser.star are correct)
+  run_without_args:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Repository
+        uses: actions/checkout@v4
+
+      - name: Setup Kurtosis
+        run: |
+          echo "deb [trusted=yes] https://apt.fury.io/kurtosis-tech/ /" | sudo tee /etc/apt/sources.list.d/kurtosis.list
+          sudo apt update
+          sudo apt install kurtosis-cli
+          kurtosis analytics disable
+
+      - name: Run Starlark
+        run: kurtosis run ${{ github.workspace }} --verbosity detailed
+
   lint:
     runs-on: ubuntu-latest
     steps:
diff --git a/main.star b/main.star
@@ -39,7 +39,9 @@ def run(plan, args):
 
     # need to do a raw get here in case only optimism_package is provided.
     # .get will return None if the key is in the config with a None value.
-    optimism_args = args.get("optimism_package") or input_parser.default_optimism_args()
+    optimism_args = (
+        args.get("optimism_package") or input_parser.default_optimism_params()
+    )
     optimism_args_with_right_defaults = input_parser.input_parser(plan, optimism_args)
     global_tolerations = optimism_args_with_right_defaults.global_tolerations
     global_node_selectors = optimism_args_with_right_defaults.global_node_selectors
diff --git a/src/package_io/input_parser.star b/src/package_io/input_parser.star
@@ -656,6 +656,12 @@ def default_op_contract_deployer_params():
 
 def default_ethereum_package_network_params():
     return {
+        "participants": [
+            {
+                "el_type": "geth",
+                "cl_type": "teku",
+            }
+        ],
         "network_params": {
             "preset": "minimal",
             "genesis_delay": 5,
@@ -670,7 +676,7 @@ def default_ethereum_package_network_params():
                     }
                 }
             ),
-        }
+        },
     }
 
 
diff --git a/src/package_io/sanity_check.star b/src/package_io/sanity_check.star
@@ -102,8 +102,28 @@ PARTICIPANT_CATEGORIES = {
         "cl_max_mem",
         "el_builder_type",
         "el_builder_image",
+        "el_builder_log_level",
+        "el_builder_extra_env_vars",
+        "el_builder_extra_labels",
+        "el_builder_extra_params",
+        "el_builder_tolerations",
+        "el_builder_volume_size",
+        "el_builder_min_cpu",
+        "el_builder_max_cpu",
+        "el_builder_min_mem",
+        "el_builder_max_mem",
         "cl_builder_type",
         "cl_builder_image",
+        "cl_builder_log_level",
+        "cl_builder_extra_env_vars",
+        "cl_builder_extra_labels",
+        "cl_builder_extra_params",
+        "cl_builder_tolerations",
+        "cl_builder_volume_size",
+        "cl_builder_min_cpu",
+        "cl_builder_max_cpu",
+        "cl_builder_min_mem",
+        "cl_builder_max_mem",
         "node_selectors",
         "tolerations",
         "count",
@@ -135,6 +155,7 @@ SUBCATEGORY_PARAMS = {
     ],
     "mev_params": ["rollup_boost_image", "builder_host", "builder_port"],
     "da_server_params": [
+        "enabled",
         "image",
         "cmd",
     ],

Original file line number	Diff line number	Diff line change
`@@ -656,6 +656,12 @@ def default_op_contract_deployer_params():`
`656`	`656`
`657`	`657`	`def default_ethereum_package_network_params():`
`658`	`658`	`return {`
	`659`	`+ "participants": [`
	`660`	`+ {`
	`661`	`+ "el_type": "geth",`
	`662`	`+ "cl_type": "teku",`
	`663`	`+ }`
	`664`	`+ ],`
`659`	`665`	`"network_params": {`
`660`	`666`	`"preset": "minimal",`
`661`	`667`	`"genesis_delay": 5,`
`@@ -670,7 +676,7 @@ def default_ethereum_package_network_params():`
`670`	`676`	`}`
`671`	`677`	`}`
`672`	`678`	`),`
`673`		`- }`
	`679`	`+ },`
`674`	`680`	`}`
`675`	`681`
`676`	`682`