Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ethpandaops/ethwallclock
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.0
Choose a base ref
...
head repository: ethpandaops/ethwallclock
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.4.0
Choose a head ref
  • 5 commits
  • 5 files changed
  • 1 contributor

Commits on Feb 7, 2025

  1. Configuration menu
    Copy the full SHA
    b34ba48 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb6e5d4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    37b96a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2025

  1. feat(beacon_chain): add stop mechanism to EthereumBeaconChain

    test(beacon_chain): add tests for concurrent stop and nil wallclock scenarios
    
    Adds a `Stop` method to the `EthereumBeaconChain` to allow for graceful shutdown of the background goroutines. This prevents goroutine leaks when the beacon chain is no longer needed.
    
    Adds tests to ensure that calling `Stop` concurrently with callback registration does not cause a race condition or panic.
    
    Adds a test to specifically address a production issue where calling `OnEpochChanged` on a nil `EthereumBeaconChain` receiver caused a panic. This test simulates the scenario where the wallclock becomes nil and verifies that the expected panic occurs, highlighting the need for nil checks before calling methods on the wallclock.
    mattevans committed Apr 23, 2025
    Configuration menu
    Copy the full SHA
    38456f7 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3 from ethpandaops/refactor/negate-potential-race

    refactor(beacon-chain): potential race to write callbacks
    mattevans authored Apr 23, 2025
    Configuration menu
    Copy the full SHA
    b65c869 View commit details
    Browse the repository at this point in the history
Loading