fix for run_external_tasks

pk910 · pk910 · commit dd5696c0d272 · 2024-08-08T13:07:58.000+02:00
diff --git a/pkg/coordinator/tasks/run_external_tasks/task.go b/pkg/coordinator/tasks/run_external_tasks/task.go
@@ -142,6 +142,7 @@ func (t *Task) Execute(ctx context.Context) error {
 	// execute child tasks
 	var resError error
 
+taskLoop:
 	for i, task := range tasks {
 		if ctx.Err() != nil {
 			return ctx.Err()
@@ -157,7 +158,7 @@ func (t *Task) Execute(ctx context.Context) error {
 		default:
 			if err != nil {
 				resError = fmt.Errorf("child task #%v failed: %w", i+1, err)
-				break
+				break taskLoop
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -142,6 +142,7 @@ func (t *Task) Execute(ctx context.Context) error {`
`142`	`142`	`// execute child tasks`
`143`	`143`	`var resError error`
`144`	`144`
	`145`	`+taskLoop:`
`145`	`146`	`for i, task := range tasks {`
`146`	`147`	`if ctx.Err() != nil {`
`147`	`148`	`return ctx.Err()`
`@@ -157,7 +158,7 @@ func (t *Task) Execute(ctx context.Context) error {`
`157`	`158`	`default:`
`158`	`159`	`if err != nil {`
`159`	`160`	`resError = fmt.Errorf("child task #%v failed: %w", i+1, err)`
`160`		`- break`
	`161`	`+ break taskLoop`
`161`	`162`	`}`
`162`	`163`	`}`
`163`	`164`	`}`