update to add syncing networks

parithosh · parithosh · commit 1db5d4fa7e87 · 2025-10-14T17:28:20.000-04:00
diff --git a/pkg/coordinator/tasks/check_eth_config/README.md b/pkg/coordinator/tasks/check_eth_config/README.md
@@ -14,6 +14,9 @@ The `check_eth_config` task verifies that all execution clients in the network r
 - **`failOnMismatch`**:
   Determines whether the task should fail if any execution client returns a different `eth_config` response. If set to `true` (default), the task fails on configuration mismatches. If set to `false`, mismatches are logged but the task continues without failure.
 
+- **`excludeSyncingClients`**:
+  When set to `true`, the task excludes execution clients that are currently syncing. If set to `false` (default), syncing clients are included in the check. This is useful for testing configuration consistency even before clients are fully synced, as `eth_config` returns configuration data that doesn't depend on sync status.
+
 ### Outputs
 
 - **`ethConfig`**:
@@ -29,6 +32,7 @@ Default settings for the `check_eth_config` task:
     clientPattern: ""
     excludeClientPattern: ""
     failOnMismatch: true
+    excludeSyncingClients: false
 ```
 
 ### Example Usage
@@ -61,6 +65,16 @@ Non-blocking check that logs mismatches but doesn't fail:
     failOnMismatch: false
 ```
 
+Only check fully synced clients:
+
+```yaml
+- name: check_eth_config
+  title: "Verify eth_config for synced clients only"
+  config:
+    excludeSyncingClients: true
+    failOnMismatch: true
+```
+
 ### Implementation Details
 
 The task queries the `eth_config` RPC method (EIP-7910) from all matching execution clients and performs a JSON-level comparison of the responses. When configurations match, the task succeeds and outputs the reference configuration. When mismatches are detected, the task provides a detailed error log showing:
diff --git a/pkg/coordinator/tasks/check_eth_config/config.go b/pkg/coordinator/tasks/check_eth_config/config.go
@@ -1,14 +1,16 @@
 package checkethconfig
 
 type Config struct {
-	ClientPattern        string `yaml:"clientPattern" json:"clientPattern"`
-	ExcludeClientPattern string `yaml:"excludeClientPattern" json:"excludeClientPattern"`
-	FailOnMismatch       bool   `yaml:"failOnMismatch" json:"failOnMismatch"`
+	ClientPattern         string `yaml:"clientPattern" json:"clientPattern"`
+	ExcludeClientPattern  string `yaml:"excludeClientPattern" json:"excludeClientPattern"`
+	FailOnMismatch        bool   `yaml:"failOnMismatch" json:"failOnMismatch"`
+	ExcludeSyncingClients bool   `yaml:"excludeSyncingClients" json:"excludeSyncingClients"`
 }
 
 func DefaultConfig() Config {
 	return Config{
-		FailOnMismatch: true,
+		FailOnMismatch:        true,
+		ExcludeSyncingClients: false,
 	}
 }
 
diff --git a/pkg/coordinator/tasks/check_eth_config/task.go b/pkg/coordinator/tasks/check_eth_config/task.go
@@ -79,7 +79,35 @@ func (t *Task) Execute(ctx context.Context) error {
 	var clients []*execution.Client
 
 	if t.config.ClientPattern == "" && t.config.ExcludeClientPattern == "" {
-		clients = clientPool.GetExecutionPool().GetReadyEndpoints(true)
+		executionPool := clientPool.GetExecutionPool()
+		allClients := executionPool.GetAllEndpoints()
+
+		if t.config.ExcludeSyncingClients {
+			clients = executionPool.GetReadyEndpoints(true)
+		} else {
+			// Include all clients regardless of sync status
+			clients = allClients
+		}
+
+		t.logger.Infof("execution pool has %d total clients, %d clients selected (excludeSyncing=%v)", len(allClients), len(clients), t.config.ExcludeSyncingClients)
+
+		// Log details about each client
+		for i, client := range allClients {
+			statusStr := "unknown"
+
+			status := client.GetStatus()
+			switch status {
+			case execution.ClientStatusOnline:
+				statusStr = "online"
+			case execution.ClientStatusOffline:
+				statusStr = "offline"
+			case execution.ClientStatusSynchronizing:
+				statusStr = "synchronizing"
+			}
+
+			t.logger.Debugf("client %d: name=%s, status=%s", i, client.GetName(), statusStr)
+		}
+
 		if len(clients) == 0 {
 			t.logger.Error("check failed: no matching clients found")
 			t.ctx.SetResult(types.TaskResultFailure)
diff --git a/playbooks/fusaka-dev/kurtosis/ethconfig-test-with-rpc-call.yaml b/playbooks/fusaka-dev/kurtosis/ethconfig-test-with-rpc-call.yaml
@@ -6,17 +6,13 @@ config:
 #walletPrivkey: ""
 tasks:
   - name: check_clients_are_healthy
-    title: "Check if at least one client is ready"
+    title: "Wait for at least one client to be responding"
     timeout: 5m
     config:
       minClientCount: 1
-  - name: check_consensus_slot_range
-    title: "Wait for slot >= 10"
-    timeout: 10m
-    config:
-      minSlotNumber: 10
   - name: check_eth_config
     title: "Check eth_config consistency across all execution clients"
     timeout: 5m
     config:
       failOnMismatch: true
+      excludeSyncingClients: false

Original file line number	Diff line number	Diff line change
`@@ -1,14 +1,16 @@`
`1`	`1`	`package checkethconfig`
`2`	`2`
`3`	`3`	`type Config struct {`
`4`		- ClientPattern string `yaml:"clientPattern" json:"clientPattern"`
`5`		- ExcludeClientPattern string `yaml:"excludeClientPattern" json:"excludeClientPattern"`
`6`		- FailOnMismatch bool `yaml:"failOnMismatch" json:"failOnMismatch"`
	`4`	+ ClientPattern string `yaml:"clientPattern" json:"clientPattern"`
	`5`	+ ExcludeClientPattern string `yaml:"excludeClientPattern" json:"excludeClientPattern"`
	`6`	+ FailOnMismatch bool `yaml:"failOnMismatch" json:"failOnMismatch"`
	`7`	+ ExcludeSyncingClients bool `yaml:"excludeSyncingClients" json:"excludeSyncingClients"`
`7`	`8`	`}`
`8`	`9`
`9`	`10`	`func DefaultConfig() Config {`
`10`	`11`	`return Config{`
`11`		`- FailOnMismatch: true,`
	`12`	`+ FailOnMismatch: true,`
	`13`	`+ ExcludeSyncingClients: false,`
`12`	`14`	`}`
`13`	`15`	`}`
`14`	`16`