This repository was archived by the owner on Aug 2, 2021. It is now read-only.
swap: fixed bug which needs cheques to be confirmed#1937
Merged
holisticode merged 3 commits intomasterfrom Nov 11, 2019
Merged
Conversation
ralph-pichler
approved these changes
Nov 8, 2019
Member
ralph-pichler
left a comment
There was a problem hiding this comment.
There are still other issues happening in the tests sometimes but they seem to be unrelated to the changes in this PR. The pending cheque bug appears to be fixed.
janos
suggested changes
Nov 11, 2019
Member
janos
left a comment
There was a problem hiding this comment.
Thanks for solving the issue. I can confirm that it is fixed by running test in the environment where failures happened frequently.
I have some comments related to data races, which should be easy to fix.
Contributor
Author
|
Thanks @janos for catching those races. I made fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in simulation tests for swap, where sometimes, due to timing issues, the test may hang because a new cheque arrives and the old one is not confirmed yet.
Fixes #1933