This repository was archived by the owner on Aug 2, 2021. It is now read-only.
DO NOT MERGE Independent services in Swarm#1676
Closed
nolash wants to merge 19 commits intoethersphere:masterfrom
Closed
DO NOT MERGE Independent services in Swarm#1676nolash wants to merge 19 commits intoethersphere:masterfrom
nolash wants to merge 19 commits intoethersphere:masterfrom
Conversation
Also skip some tests that need Kademlia API rehab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been experimenting with separating out the different swarm services to independent registrations in node.Service, as well as extracting the kademlia to a separate API and drafted a POC on how pss can interact with it.
The untidy results can be found in this PR.
I've done some band-aiding and some skipping of tests, so this does not claim in any way to be code that should be reviewed as a merge candidate. It is merely meant as an outline for discussing whether this is a path to pursue.
It does however pass most tests in pss and network, and the binary (which for the time being leaves out swap, api, streamer) does also compile and run.
The incremental steps that passed all relevant tests can be inspected here if of interest;