there is an occasional, hard-to-reproduce bug occurring in swap/simulations_tests.go.

it looks like this:

--- FAIL: TestPingPongChequeSimulation (1.94s)
    simulations_test.go:327: expected cumulative payout to be 412298906469954, but is 431932187730428

it's currently unknown whether this is a proper bug, or something wrong with the sim tests themselves. things are pointing towards the former.

tests known to be affected by this bug:

• TestPingPongChequeSimulation
• TestMultiChequeSimulation

high count values when running swap tests can sometimes trigger the bug, e.g.:

go test ./swap -count=30

hence the bug is suspected to have something to do with concurrency/synchronization.

the incentives-simulations-bug branch is available for repeating CI tests under PR #1893.