Skip to content
This repository was archived by the owner on Aug 2, 2021. It is now read-only.
This repository was archived by the owner on Aug 2, 2021. It is now read-only.

v0.4.0 is connecting with v0.3.11 #1402

Closed
Closed
v0.4.0 is connecting with v0.3.11#1402
Labels
bug
@nonsense

Description

@nonsense
nonsense
opened on May 20, 2019

Even though we bumped up protocol version for bzz, nodes still connect, for example, when running Swarm v0.4.0 (bzz/9 and hive/8) we still connect to peers that have (bzz/8 and hive/8).

}, {
    caps: ["bzz/8", "hive/8"],
    enode: "enode://4c113504601930bf2000c29bcd98d1716b6167749f58bad703bae338332fe93cc9d9204f08afb44100dc7bea479205f5d162df579f9a8f76f8b402d339709023@3.122.203.99:30301",
    id: "1401ec8b40b23cb2bbbff4e8e9cdbf0e7f0288f453b077dad7d6cdab08ee86ed",
    name: "swarm/v0.3.11/linux-amd64/go1.11.5",
    network: {
      inbound: false,
      localAddress: "192.168.225.158:44480",
      remoteAddress: "3.122.203.99:30301",
      static: true,
      trusted: false
    },
    protocols: {
      hive: "handshake"
    }
}, {

AFAIK bzz/8 handshare (which checks bzz network id) should be performed before running the Hive protocol, which doesn't seem to be the case here.

The peer above is running bzz network id 3, whereas v0.4.0 is running bzz network id 4.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions