feat: update specs for the dispute game factory interface#709
Merged
stevennevins merged 2 commits intomainfrom May 29, 2025
Merged
feat: update specs for the dispute game factory interface#709stevennevins merged 2 commits intomainfrom
stevennevins merged 2 commits intomainfrom
Conversation
maurelian
reviewed
May 22, 2025
maurelian
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
IDisputeGameFactoryinterface inspecs/fault-proof/stage-one/dispute-game-interface.md.Changes:
setImplementationfunction now acceptsbytes calldata _argsfor chain-specific configurations.gameArgs(GameType) returns (bytes)getter for these configurations.Tests
N/A (Documentation update for an interface). Existing tests will be updated to align with the new new mechanism to parse and pass these configurations
Additional context
Supports the initiative to make
FaultDisputeGameimplementations reusable by externalizing chain-specific configurations.Metadata