interop: add OptimismSuperchainERC20Factory to predeploys#332
Conversation
specs/interop/predeploys.md
Outdated
|
|
||
| ### OptimismSuperchainERC20 | ||
|
|
||
| The `OptimismSuperchainERC20Factory` creates ERC20 contracts that compile to the `SuperchainERC20` [standard](token-bridging.md) |
There was a problem hiding this comment.
nit: "compile to" -> "implement"
specs/interop/predeploys.md
Outdated
|
|
||
| | Constant | Value | | ||
| | -------- | ----- | | ||
| | Address | TBD | |
There was a problem hiding this comment.
0x4200000000000000000000000000000000000026 is the next available address
specs/interop/predeploys.md
Outdated
| This will ensure the same address deployment across different chains, | ||
| which is necessary for the [standard](token-bridging.md) implementation. | ||
| The safest way to use `CREATE3` is through | ||
| [CreateX](https://github.com/pcaversaccio/createx), which will be a preinstall in the OP stack. |
There was a problem hiding this comment.
Using language like "will be" results in stale specs, you can assume that its part of the OP Stack already here
Yes it should be, we will want to include it in |
Personally i would vote on moving away from past tense but we should not bikeshed on this for too long and just pick something, there exist events that are not past tense that cannot be modified |
I like the simple name |
I think moving the changes to |
what would you prefer instead? Something like |
Will do in this PR.
Do you know what the fromAddress could be in this case? |
|
@tynes I just pushed a new update addressing your comments.
|
|
Also pushed an update to the Let me know if I should remove this change from this PR |
Description
Updates the
predeploys.mdfile to include theSuperchainERC20Factoryspecs, as a follow up to the Design DocCloses #10873
Some comments and open questions:
predeploys.mdfile?createOptimismSuperchainERC20andOptimismMintableERC20Created) are following the structure from theOptimismMintableERC20Factory. We can change it to something simpler, likedeploy, wdyt?OptimismMintableERC20Createdincluded the token metadata and did not have the deployer address. I removed the metadata to be in sync with theOptimismMintableERC20Createdevent. Metadata can later be fetched from the superToken address. Any take on this?L2StandardBridgein the same file to cover the changes? we already have aliquidity-migration.mdfile that explains it, but it makes sense to have it repeated here I think.