You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 18, 2022. It is now read-only.
This allows us to put kall directly into inline yul, by making the kall builtin use imaginary opcodes which don't get transpiled. (Still gets find-replaced at the end, of course!)
Update: I am not gonna merge this one until we've used the soljson.js file in local testing with the contracts. This has been published here in a way that we can use a custom version before updating the main json!
Can I propose that we come up with a different name than kall? Maybe em_call? It seems like kall is just a modification of call with a letter making the opcode name sound like the word "call", but it doesn't really say much about what this function is actually doing. This may be out of scope for this pull request.
@snario I want to merge this PR now that it's confirmed working but agree naming could be improved. Maybe Yul IR compiler is the right time to make the switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows us to put
kalldirectly into inline yul, by making thekallbuiltin use imaginary opcodes which don't get transpiled. (Still gets find-replaced at the end, of course!)