Skip to content
This repository was archived by the owner on Dec 12, 2023. It is now read-only.

refactor: replace unit tests with integration tests#9

Merged
smartcontracts merged 38 commits intomainfrom
refactor/unit-for-integration-tests
Mar 31, 2021
Merged

refactor: replace unit tests with integration tests#9
smartcontracts merged 38 commits intomainfrom
refactor/unit-for-integration-tests

Conversation

@platocrat
Copy link
Copy Markdown
Contributor

@platocrat platocrat commented Mar 17, 2021

Temporarily addresses the ethereumjs-vm issue when using @eth-optimism/plugins to run OVM unit tests

@platocrat platocrat self-assigned this Mar 17, 2021
@platocrat platocrat marked this pull request as draft March 17, 2021 03:08
@platocrat platocrat added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Mar 17, 2021
@platocrat platocrat mentioned this pull request Mar 22, 2021
Closed
@snario
Copy link
Copy Markdown

snario commented Mar 23, 2021

Hey @platocrat — when do you think this will be ready to review?

@platocrat
Copy link
Copy Markdown
Contributor Author

platocrat commented Mar 23, 2021

@snario today or tomorrow, depending on how fast I can turn the hardhat-deploy fork into a plugin.

K-Ho
K-Ho reviewed Mar 25, 2021
View reviewed changes
K-Ho
K-Ho reviewed Mar 25, 2021
View reviewed changes
K-Ho
K-Ho reviewed Mar 25, 2021
View reviewed changes
@platocrat platocrat force-pushed the refactor/unit-for-integration-tests branch from 55262fb to bf981b5 Compare March 26, 2021 02:01
@platocrat platocrat marked this pull request as ready for review March 26, 2021 17:59
snario
snario reviewed Mar 30, 2021
View reviewed changes
snario
snario reviewed Mar 30, 2021
View reviewed changes
snario
snario reviewed Mar 30, 2021
View reviewed changes
snario
snario reviewed Mar 30, 2021
View reviewed changes
snario
snario reviewed Mar 30, 2021
View reviewed changes
snario
snario reviewed Mar 30, 2021
View reviewed changes
snario
snario reviewed Mar 30, 2021
View reviewed changes
snario
snario reviewed Mar 30, 2021
View reviewed changes
snario
snario reviewed Mar 30, 2021
View reviewed changes
K-Ho
K-Ho suggested changes Mar 30, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@K-Ho K-Ho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!! Mostly minor changes - Major change would be deciding between the two options of 1. starting as a Vanilla EVM project and adding all OVM functionality and
2. Starting as a full OVM project and just having the README describe the different components

Also ideally we have a single test script that can run for the OVM if we add TARGET=OVM

annieke
annieke reviewed Mar 30, 2021
View reviewed changes
Copy link
Copy Markdown

@annieke annieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't have a chance to run this locally, but did a first pass review reading the guide! i really like the voice you used writing this, felt very encouraged throughout haha

@smartcontracts smartcontracts merged commit d909b40 into main Mar 31, 2021
@smartcontracts smartcontracts deleted the refactor/unit-for-integration-tests branch March 31, 2021 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@smartcontracts smartcontracts Awaiting requested review from smartcontracts

3 more reviewers

@snario snario snario left review comments

@K-Ho K-Ho K-Ho requested changes

@annieke annieke annieke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@platocrat platocrat

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@platocrat @snario @K-Ho @annieke @smartcontracts