fix[hardhat-ovm]: Allow for private key config option for signers#946
Merged
gakonst merged 1 commit intoethereum-optimism:developfrom May 25, 2021
Merged
fix[hardhat-ovm]: Allow for private key config option for signers#946gakonst merged 1 commit intoethereum-optimism:developfrom
gakonst merged 1 commit intoethereum-optimism:developfrom
Conversation
🦋 Changeset detectedLatest commit: bd7ffd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This LGTM. @shanefontaine does this fix the issue you were having? |
Contributor
|
Also needs a changeset! Need to run |
|
Yes, these changes and the changes in #935 seem to resolve all of my issues. |
Contributor
|
Great! @miguelmota once you add a changeset, feel free to hit "ready for review" and I'll give this an approval. |
Contributor
Author
|
@smartcontracts let me know if this needs anything else. Thanks!! |
gakonst
approved these changes
May 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the hardhat-ovm plugin isn't allowing for private keys for accounts from hardhat.config.js (it's always looking for mnemonic). This PR adds support for private key account config option as allowed by hardhat config.
Additional context
Metadata