Skip to content

feat(op-node): testlog alignment and color by default#2854

Merged
mergify[bot] merged 1 commit intodevelopfrom
pretty-testlog
Jun 27, 2022
Merged

feat(op-node): testlog alignment and color by default#2854
mergify[bot] merged 1 commit intodevelopfrom
pretty-testlog

Conversation

@protolambda
Copy link
Copy Markdown
Contributor

Logs in go tests (including e2e) in bedrock now have aligned lines and color.

New:
pretty

Old:
ugly_000

The improved readability is especially nice when testing things with a mix of long and short file names, and important log kev-value pairs to compare.

Maybe it's worth upstreaming into Geth for their testing too?

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 27, 2022

⚠️ No Changeset found

Latest commit: f605f28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@protolambda
Copy link
Copy Markdown
Contributor Author

Rebased on develop to hopefully fix a linting issue (was previously based on older develop branch commit that didn't have linting changes of CI yet)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit e523a7f into develop Jun 27, 2022
@mergify mergify bot deleted the pretty-testlog branch June 27, 2022 23:08
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants