Skip to content

Fix linting issues in bedrock package#2824

Merged
mergify[bot] merged 3 commits intoethereum-optimism:developfrom
maurelian:m/fix-json-lint
Jun 20, 2022
Merged

Fix linting issues in bedrock package#2824
mergify[bot] merged 3 commits intoethereum-optimism:developfrom
maurelian:m/fix-json-lint

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

Description

This PR:

  1. Adds the deployments folder to .eslintignore and .prettierignore.
  2. Changes the yarn lint:ts:check command so that it throws an error on warnings. This prevents the issue where warnings don't cause an error in CI, but yarn lint:ts:fix will modify the code anyways. The approach used is consistent with other packages.
  3. Formats the hardhat config file.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 20, 2022

⚠️ No Changeset found

Latest commit: 0e19660

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 20, 2022

Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 20, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 20, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@maurelian
Copy link
Copy Markdown
Contributor Author

Should not require a changeset IMO

@mergify mergify bot removed the conflict label Jun 20, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 20, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit b09bc9b into ethereum-optimism:develop Jun 20, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 20, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 20, 2022
@maurelian maurelian deleted the m/fix-json-lint branch June 21, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants