Skip to content

feat(dev-env): Pin yarn version#2806

Merged
mergify[bot] merged 3 commits intodevelopfrom
willc/pin-yarn
Jun 21, 2022
Merged

feat(dev-env): Pin yarn version#2806
mergify[bot] merged 3 commits intodevelopfrom
willc/pin-yarn

Conversation

@roninjin10
Copy link
Copy Markdown
Contributor

@roninjin10 roninjin10 commented Jun 16, 2022

Yarn is a small (or at least smaller than you'd expect) javascript file. Committing it in the monorepo guarantees that anybody using the monorepo is all using the latest and consistent version of yarn. Run yarn update:yarn to update the version.

This matches what we did in gateway in this pr https://github.com/ethereum-optimism/gateway/pull/417

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 16, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 86b97b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@roninjin10
Copy link
Copy Markdown
Contributor Author

roninjin10 commented Jun 16, 2022

Messed up git commits completely fixing

mslipper
mslipper suggested changes Jun 16, 2022
View reviewed changes
@roninjin10
Copy link
Copy Markdown
Contributor Author

roninjin10 commented Jun 16, 2022

@mslipper i messed up my git but fixed.

Seperately, I included a changeset that minor bumps every package but that seems odd since I technically changed 0 packages here.

@roninjin10 roninjin10 requested a review from mslipper June 16, 2022 22:22
@mslipper
Copy link
Copy Markdown
Contributor

mslipper commented Jun 16, 2022

You don't need that changeset - the Mergify comment is just a reminder 😄

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 21, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 21, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit a6f3be0 into develop Jun 21, 2022
@mergify mergify bot deleted the willc/pin-yarn branch June 21, 2022 17:30
@mergify mergify bot removed the on-merge-train label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@smartcontracts smartcontracts Awaiting requested review from smartcontracts

+1 more reviewer

@mslipper mslipper mslipper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roninjin10 @mslipper @tynes