fix: switch between empty/forked chain without the need to recreate t…#2795
Merged
tynes merged 1 commit intoethereum-optimism:developfrom Jun 23, 2022
EthereansOS:develop
Merged
fix: switch between empty/forked chain without the need to recreate t…#2795tynes merged 1 commit intoethereum-optimism:developfrom EthereansOS:develop
tynes merged 1 commit intoethereum-optimism:developfrom
EthereansOS:develop
Conversation
🦋 Changeset detectedLatest commit: 800aec5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
Contributor
|
Can you add a changeset for the hardhat package? |
Contributor
Author
Done |
tynes
approved these changes
Jun 21, 2022
mslipper
approved these changes
Jun 22, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
Merge failed. Please see automated check logs for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…he entire image
Description
Currently
l1_chainDocker image doesn't allow to fork a preexistent chain because thedotenvrepo is not loaded nor initialized. Adding the latter to thepackage.jsonand using it in thehardhat.config.jsfile solves the issue.Additional context
The current image works well if you need to run a fresh L1 chain. However, the
l1_chain.envconfiguration file is not read correctly by the container, so it's not possible to use a forked mainnet.Metadata
No issues links