Skip to content

feat(contracts): deposit gas metering via 1559#2575

Merged
mergify[bot] merged 5 commits intodevelopfrom
sc/ctb-deposit-gas-metering
Jun 3, 2022
Merged

feat(contracts): deposit gas metering via 1559#2575
mergify[bot] merged 5 commits intodevelopfrom
sc/ctb-deposit-gas-metering

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts commented May 17, 2022 •
edited by trianglesphere
Loading

Description
Implements deposit gas metering via a 1559-like mechanism.

TODO:

  • Fix bug preventing tests from running
  • Add tests

Metadata

  • Fixes ENG-2187

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 17, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9f6c8f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from mslipper and tuxcanfly May 17, 2022 21:57
@smartcontracts smartcontracts force-pushed the sc/ctb-deposit-gas-metering branch from c1bab83 to 65e010e Compare May 17, 2022 22:07
tynes
tynes reviewed May 17, 2022
View reviewed changes
tynes
tynes reviewed May 17, 2022
View reviewed changes
@trianglesphere trianglesphere mentioned this pull request May 17, 2022
Closed
@smartcontracts smartcontracts force-pushed the sc/ctb-deposit-gas-metering branch 3 times, most recently from 3109b12 to 0a8e336 Compare May 18, 2022 17:55
@smartcontracts smartcontracts marked this pull request as ready for review May 18, 2022 18:25
trianglesphere
trianglesphere reviewed May 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments explaining stuff

trianglesphere
trianglesphere previously requested changes May 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One important parameter to set and a couple small comments. Otherwise this is looking really good.

@trianglesphere
Copy link
Copy Markdown
Contributor

trianglesphere commented May 18, 2022

FYI: I added fixes metadata to this PR

@trianglesphere trianglesphere mentioned this pull request May 18, 2022
Closed
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 18, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label May 18, 2022
protolambda
protolambda reviewed May 19, 2022
View reviewed changes
tynes
tynes reviewed May 19, 2022
View reviewed changes
@smartcontracts smartcontracts force-pushed the sc/ctb-deposit-gas-metering branch 3 times, most recently from f77dcf4 to 5238682 Compare May 19, 2022 18:15
@mergify mergify bot removed the conflict label May 19, 2022
@smartcontracts smartcontracts force-pushed the sc/ctb-deposit-gas-metering branch 3 times, most recently from 8467dde to 3c37bd0 Compare May 19, 2022 18:38
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 19, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@smartcontracts smartcontracts force-pushed the sc/ctb-deposit-gas-metering branch 3 times, most recently from aa41eb9 to dd8560d Compare May 19, 2022 19:28
tynes
tynes requested changes Jun 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@tynes tynes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attempting to fix the build

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 3, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 3, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mslipper mslipper mentioned this pull request Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@maurelian maurelian maurelian approved these changes

@mslipper mslipper Awaiting requested review from mslipper

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

+2 more reviewers

@trianglesphere trianglesphere trianglesphere left review comments

@protolambda protolambda protolambda left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smartcontracts @trianglesphere @tynes @maurelian @protolambda