Skip to content

added internal/external import seperation on integration tests#2202

Merged
mslipper merged 1 commit intoethereum-optimism:developfrom
tonykogias:internal-external-imports-seperation-in-integration-tests
Mar 2, 2022
Merged

added internal/external import seperation on integration tests#2202
mslipper merged 1 commit intoethereum-optimism:developfrom
tonykogias:internal-external-imports-seperation-in-integration-tests

Conversation

@tonykogias
Copy link
Copy Markdown
Contributor

@tonykogias tonykogias commented Feb 11, 2022

Description
Added internal/external import seperation on integration tests

Metadata

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 11, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0d100da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-integration Area: integration tests label Feb 11, 2022
@tonykogias tonykogias marked this pull request as draft February 15, 2022 17:35
@tonykogias tonykogias marked this pull request as ready for review February 15, 2022 17:35
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 15, 2022 •
edited
Loading

Codecov Report

Merging #2202 (0d100da) into develop (e0f7e5f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2202   +/-   ##
========================================
  Coverage    73.35%   73.35%           
========================================
  Files           84       84           
  Lines         2766     2766           
  Branches       472      472           
========================================
  Hits          2029     2029           
  Misses         737      737
Flag Coverage Δ
batch-submitter 62.63% <ø> (ø)
contracts 90.48% <ø> (ø)
core-utils 87.80% <ø> (ø)
data-transport-layer 36.89% <ø> (ø)
sdk 59.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f7e5f...0d100da. Read the comment docs.

@mslipper
Copy link
Copy Markdown
Contributor

mslipper commented Mar 2, 2022

Thank you!

@mslipper mslipper merged commit d0853b1 into ethereum-optimism:develop Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mslipper mslipper mslipper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-integration Area: integration tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Separate internal and external imports within integration tests

3 participants

@tonykogias @codecov-commenter @mslipper