Skip to content

op-node/derive: drop malformed span batch tx data as NotEnoughData#19502

Merged
sebastianst merged 1 commit intodevelopfrom
seb/fix-19494-span-batch-derive-error
Mar 12, 2026
Merged

op-node/derive: drop malformed span batch tx data as NotEnoughData#19502
sebastianst merged 1 commit intodevelopfrom
seb/fix-19494-span-batch-derive-error

Conversation

@sebastianst
Copy link
Copy Markdown
Member

Summary

  • Fixes unclassified error propagation from DeriveSpanBatch in ChannelInReader.NextBatch
  • Malformed span batch data (bad tx type, invalid encoding) now returns NotEnoughData for immediate drop instead of triggering O(N×backoff) drain
  • Critical errors (logic errors) from DeriveSpanBatch still propagate as-is

Closes #19494. Part of #19491.

🤖 Generated by Claude Code

Classifies non-critical errors from DeriveSpanBatch (malformed tx type,
invalid encoding, etc.) as NotEnoughData so the pipeline drops the batch
immediately without backoff. Critical errors (logic errors) still
propagate as-is.

Fixes #19494.
@sebastianst sebastianst requested review from a team and joshklop March 12, 2026 16:19
@sebastianst sebastianst added this pull request to the merge queue Mar 12, 2026
Merged via the queue into develop with commit 218bff0 Mar 12, 2026
96 checks passed
@sebastianst sebastianst deleted the seb/fix-19494-span-batch-derive-error branch March 12, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

op-node/derive: malformed span batch tx data propagates as unclassified error causing O(N×backoff) drain

2 participants