op-node/derive: CriticalError for missing beacon endpoint after Ecotone#19501
Merged
sebastianst merged 1 commit intodevelopfrom Mar 12, 2026
Merged
op-node/derive: CriticalError for missing beacon endpoint after Ecotone#19501sebastianst merged 1 commit intodevelopfrom
sebastianst merged 1 commit intodevelopfrom
Conversation
…red after Ecotone Wraps the "beacon endpoint not configured" error with NewCriticalError so the node stops with a clear fatal error instead of retrying indefinitely on an unrecoverable operator misconfiguration. Fixes #19495.
ajsutton
approved these changes
Mar 12, 2026
Contributor
ajsutton
left a comment
There was a problem hiding this comment.
LGTM. We should just make --l1.beacon a required flag now (if we haven't already).
Member
Author
|
There's already a check for this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataSourceFactory.OpenData: wraps the "beacon endpoint not configured" error withNewCriticalErrorso the node stops with a clear fatal error instead of retrying indefinitelyRunning a post-Ecotone node without
--l1.beaconis an unrecoverable operator misconfiguration. The previous unclassified error caused infinite backoff+retry with misleadingError-level logs instead of a clean node halt.Closes #19495. Part of #19491.
🤖 Generated by Claude Code