op-node/derive: drop pre-Delta span batch as NotEnoughData#19500
Merged
sebastianst merged 1 commit intodevelopfrom Mar 12, 2026
Merged
op-node/derive: drop pre-Delta span batch as NotEnoughData#19500sebastianst merged 1 commit intodevelopfrom
sebastianst merged 1 commit intodevelopfrom
Conversation
Returns NotEnoughData instead of NewTemporaryError when a span batch is encountered before Delta activation. This drains the channel immediately rather than taking O(N×backoff) cycles. Fixes #19493.
ajsutton
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChannelInReader.NextBatch: returnsNotEnoughData(immediate continue, no backoff) instead ofNewTemporaryErrorThe comment in the old code said "early dropping invalid batches as soon as possible", but
NewTemporaryErrordid the opposite — it triggered backoff+retry, leavingcr.nextBatchFnset so each retry consumed the next bad batch.Closes #19493. Part of #19491.
🤖 Generated by Claude Code