chore: return migrator address on ReadImplementationAddresses output#19076
Merged
smartcontracts merged 7 commits intodevelopfrom Feb 5, 2026
Merged
chore: return migrator address on ReadImplementationAddresses output#19076smartcontracts merged 7 commits intodevelopfrom
smartcontracts merged 7 commits intodevelopfrom
Conversation
…819) * chore: return migrator address on ReadImplementationAddresses output * chore: use fixed solidity version * chore: just pr ready * test: add zero length code test for opcm
The test referenced input_.delayedWETHPermissionedGameProxy which doesn't exist in the ReadImplementationAddresses.Input struct. The delayedWETH implementation is read from OPCM's implementations() return value, not from an input proxy address. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19076 +/- ##
==========================================
+ Coverage 76.3% 81.0% +4.6%
==========================================
Files 188 133 -55
Lines 10943 6913 -4030
==========================================
- Hits 8356 5600 -2756
+ Misses 2441 1313 -1128
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
stevennevins
reviewed
Feb 4, 2026
packages/contracts-bedrock/test/scripts/ReadImplementationAddresses.t.sol
Show resolved
Hide resolved
The test was using the `opcm` variable directly, which is only set when OPCM_V2 feature is disabled. Added `_opcm()` helper to return the correct instance based on the feature flag. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
JosepBove
approved these changes
Feb 5, 2026
maurelian
approved these changes
Feb 5, 2026
Contributor
|
I think it looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pushing up the wonderland branch upstream to bypass CI issues