batch-submitter: ENG-1688 fix bug causing Kovan to fall behind#1799
batch-submitter: ENG-1688 fix bug causing Kovan to fall behind#1799tynes merged 1 commit intoethereum-optimism:developfrom
Conversation
🦋 Changeset detectedLatest commit: 85f68bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #1799 +/- ##
===========================================
+ Coverage 71.81% 71.90% +0.08%
===========================================
Files 69 69
Lines 2303 2310 +7
Branches 344 345 +1
===========================================
+ Hits 1654 1661 +7
Misses 649 649
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Left the same comment in our other thread but why did a nonce error trigger on the batch submitter? |
| maxGasPrice: ynatm.toGwei(config.maxGasPriceInGwei), | ||
| gasPriceScalingFunction: ynatm.LINEAR(config.gasRetryIncrement), | ||
| delay: config.resubmissionTimeout, | ||
| rejectImmediatelyOnCondition: ynatmRejectOn, |
There was a problem hiding this comment.
Is the idea that the batch submitter will catch this exception and try again?
There was a problem hiding this comment.
Based on the test, that looks like it is the case
There was a problem hiding this comment.
It will abort the retry loop on either reverts or nonce errors so that we can try submitting the full batch again. This will update the nonce.
tynes
left a comment
There was a problem hiding this comment.
Lets get this deployed on kovan asap
I don't have the root cause of the nonce error. It may be related to the race condition I mentioned on Slack, but I'm not sure. I can dig deeper, but I think we should get this PR out first because it'll at the very least allow the batch submitter to keep submitting batches while we investigate. |
YNATM was retrying transactions with bad nonces for up to an hour on Kovan. This PR causes YNATM to immediately reject when bad nonce errors are encountered.