Post deployment verification script#1727
Merged
Conversation
🦋 Changeset detectedLatest commit: 5c62a2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a391a63 to
70c46bf
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1727 +/- ##
===========================================
+ Coverage 71.81% 71.87% +0.05%
===========================================
Files 69 67 -2
Lines 2303 2176 -127
Branches 344 327 -17
===========================================
- Hits 1654 1564 -90
+ Misses 649 612 -37
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
a578f38 to
439a515
Compare
59ea8de to
714ac0d
Compare
625d036 to
97287a1
Compare
ben-chain
reviewed
Nov 10, 2021
Collaborator
ben-chain
left a comment
There was a problem hiding this comment.
Additional validation which I can think of is:
- verify that
AM.owner == multisig.address
d7dddc6 to
2049794
Compare
7818da5 to
df241ab
Compare
maurelian
commented
Nov 11, 2021
Comment on lines
4
to
16
Contributor
Author
There was a problem hiding this comment.
Improves the UX of running these scripts, by allowing the user to review and process each step before moving on.
Contributor
Author
There was a problem hiding this comment.
Makes the wall of text easier to read.
Contributor
Author
There was a problem hiding this comment.
Kind of an ugly function, but it makes the scripts much cleaner.
Contributor
Author
There was a problem hiding this comment.
Make this more consistent with the other prompts.
df241ab to
af390ba
Compare
Contributor
|
Rebased on develop |
1a76419 to
9064681
Compare
132e6eb to
984c0fb
Compare
984c0fb to
8165e12
Compare
smartcontracts
approved these changes
Nov 11, 2021
feat: Add task-utils, with interactive user prompt feat: Add colors to printed strings fix: Detect network name refactor: Extract comparison and logs into printComparison() feat: validate source code of all updated addresses fix: await isHardhatNode fix: Remove todo comments refactor: Extract to getContractArtifacts feat: Add validation of libAddressManager fix: allow passing URL as an arg fix: batches contract name improve logging Validation: lots of logging improvements feat: Add validate ChugSplashDictator fix: truncateLongString should return at least 32 bytes refactor: Rename task-utils to validation-utils fixup! feat: Add validate ChugSplashDictator fix: truncateLongString should return at least 32 bytes refactor: Rename task-utils to validation-utils
8165e12 to
5c62a2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an early iteration on the script to validate deployments. I'd like to get it reviewed, or even merged, to validate the direction.
How to test:
export CONTRACTS_RPC_URL=https://kovan.infura.io/v3/YOURKEYHERE