Skip to content

workflows: fix build-args syntax#1653

Merged
tynes merged 1 commit intodevelopfrom
fix/ci-build-args-syntax
Oct 29, 2021
Merged

workflows: fix build-args syntax#1653
tynes merged 1 commit intodevelopfrom
fix/ci-build-args-syntax

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented Oct 29, 2021

Description

The docs specify that build-args for the Github action
docker/build-push-action@v2 should be a list, but
doing so results in an error:

The workflow is not valid. .github/workflows/release.yml (Line: 362, Col: 13): A sequence was not expected

This updates the syntax to copy the example here:
https://github.com/docker/build-push-action/blob/3c507bedc4de3249e107413a7358ae1af558fd79/UPGRADE.md#L68

Uncertain if the env var parsing will work with this syntax

@tynes
workflows: fix build-args syntax
6a8a4a9 
The docs specify that `build-args` for the Github action
`docker/build-push-action@v2` should be a list, but
doing so results in an error:

`The workflow is not valid. .github/workflows/release.yml (Line: 362,
Col: 13): A sequence was not expected`

This updates the syntax to copy the example here:
https://github.com/docker/build-push-action/blob/3c507bedc4de3249e107413a7358ae1af558fd79/UPGRADE.md#L68

Uncertain if the env var parsing will work with this syntax
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 29, 2021

⚠️ No Changeset found

Latest commit: 6a8a4a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tynes tynes requested a review from mslipper October 29, 2021 18:08
@github-actions github-actions bot added 2-reviewers M-ci Meta: ci related work labels Oct 29, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 29, 2021 •
edited
Loading

Codecov Report

Merging #1653 (6a8a4a9) into develop (240e62e) will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1653      +/-   ##
===========================================
- Coverage    76.52%   76.26%   -0.26%     
===========================================
  Files           82       80       -2     
  Lines         3041     2932     -109     
  Branches       466      453      -13     
===========================================
- Hits          2327     2236      -91     
+ Misses         714      696      -18
Flag Coverage Δ
batch-submitter 61.74% <ø> (ø)
contracts 86.05% <ø> (ø)
core-utils 63.27% <ø> (ø)
data-transport-layer 37.86% <ø> (ø)
message-relayer ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/message-relayer/hardhat.config.ts
packages/message-relayer/src/relay-tx.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 240e62e...6a8a4a9. Read the comment docs.

@tynes tynes merged commit dc2126a into develop Oct 29, 2021
@tynes tynes deleted the fix/ci-build-args-syntax branch October 29, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mslipper mslipper mslipper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

M-ci Meta: ci related work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tynes @codecov-commenter @mslipper