Skip to content

fix: event value in ETHLockbox and improve tests coverage#14934

Merged
smartcontracts merged 1 commit intodevelopfrom
sc-feat/fix-event-and-test
Mar 19, 2025
Merged

fix: event value in ETHLockbox and improve tests coverage#14934
smartcontracts merged 1 commit intodevelopfrom
sc-feat/fix-event-and-test

Conversation

@agusduha
Copy link
Copy Markdown
Contributor

@agusduha agusduha commented Mar 18, 2025

Description

  • Fix balance amount emitted on LiquidityMigrated event

Tests

  • Fix and improve testFuzz_migrateLiquidity_succeeds test coverage
  • Add unit tests for ProxyAdminOwnedBase contract

@0xDiscotech
fix: event value and improve tests coverage (#337)
a6e6eb3 
* test: add proxy admin owned base unit tests

* fix: event value and migration test coverage

* chore: pre pr
@agusduha agusduha self-assigned this Mar 18, 2025
@agusduha agusduha requested a review from a team as a code owner March 18, 2025 21:27
@agusduha agusduha requested a review from mbaxter March 18, 2025 21:27
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.29%. Comparing base (6638905) to head (a6e6eb3).
Report is 6 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #14934      +/-   ##
===========================================
- Coverage    46.33%   46.29%   -0.04%     
===========================================
  Files         1126     1126              
  Lines        97617    97618       +1     
===========================================
- Hits         45226    45188      -38     
- Misses       49111    49146      +35     
- Partials      3280     3284       +4
Flag Coverage Δ
cannon-go-tests-32 62.08% <ø> (ø)
cannon-go-tests-64 57.13% <ø> (ø)
contracts-bedrock-tests 94.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/contracts-bedrock/src/L1/ETHLockbox.sol 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@smartcontracts
Copy link
Copy Markdown
Contributor

smartcontracts commented Mar 19, 2025

/ci authorize a6e6eb3

@smartcontracts smartcontracts added the M-exempt-frozen-files Meta: Exempt from frozen code label Mar 19, 2025
@smartcontracts smartcontracts added this pull request to the merge queue Mar 19, 2025
Merged via the queue into develop with commit e4b921c Mar 19, 2025
49 checks passed
@smartcontracts smartcontracts deleted the sc-feat/fix-event-and-test branch March 19, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

@mbaxter mbaxter Awaiting requested review from mbaxter mbaxter is a code owner automatically assigned from ethereum-optimism/contract-reviewers

Assignees

@agusduha agusduha

Labels

M-exempt-frozen-files Meta: Exempt from frozen code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agusduha @smartcontracts @0xDiscotech