Skip to content

feat: introduce SharedLockbox#14199

Merged
mslipper merged 62 commits intofeat/interop-stable-devnetfrom
sc-feat/add-shared-lockbox
Feb 6, 2025
Merged

feat: introduce SharedLockbox#14199
mslipper merged 62 commits intofeat/interop-stable-devnetfrom
sc-feat/add-shared-lockbox

Conversation

@mslipper
Copy link
Copy Markdown
Contributor

@mslipper mslipper commented Feb 6, 2025

Replaces #13144.

0xDiscotech and others added 30 commits November 20, 2024 18:24
* feat: create shared lockbox contract with its interface and unit tests

* chore: polish tests and interfaces

* chore: run pre-pr

* chore: improve natspec

* chore: run pre-pr

* chore: update compiler version
* feat: integrate portal to lockbox

* fix: pr fixes

* test: refactor assert
#128)

* feat: create shared lockbox contract with its interface and unit tests

* chore: polish tests and interfaces

* chore: run pre-pr

* chore: improve natspec

* chore: run pre-pr

* feat: add liqudity migrator contract with its unit test and interface

* chore: remove underscore on stack var

* chore: add todo

* chore: run pre-pr

* chore: add contract title natspec and proxied

* refactor: integrate testing suite with common test

* chore: pre-pr

* chore: add spec test
* feat: integrate portal to lockbox

* fix: pr fixes

* test: refactor assert

* feat: integrate system config with superchain config

* fix: remove OPCM interop

* test: add dependency counter test
* feat: Add pause check

Co-authored-by: 0xParticle <particle@defi.sucks>
Co-authored-by: gotzenx <78360669+gotzenx@users.noreply.github.com>
Co-authored-by: Joxess <joxes@defi.sucks>

* test: add tests natspecs

---------

Co-authored-by: 0xParticle <particle@defi.sucks>
Co-authored-by: gotzenx <78360669+gotzenx@users.noreply.github.com>
Co-authored-by: Joxess <joxes@defi.sucks>
* feat: use superchain config lockbox in portal

* test: add new sharedlockbox test
…ox-3

fix: merge conflict in develop sync
* feat: liquidity migrator deployment

* test: fix comment

* test: fix internal variables names
* feat: dependency set refactor

* fix: deploy script variable name

* fix: pr

* fix: pr
* chore: partial implementation comments

* feat: new lockbox

* feat: introduce dependency manager predeploy

* feat: remove timestamp check from CrossL2Inbox

* feat: introduce cluster manager role and remove immutables

* fix: remove unnecessary code, fix tests and setup

* feat: use unstructured storage and OZ v5

* fix: L2ToL2CDM dependency set check

* fix: dependency manager gas limit

* feat: refactor interop feature contracts (#200)

* feat: refactor interop feature contracts

* fix: add noops comment

* feat: adds OptimismPortal migrated flag

* test: add missing tests

* fix: portal interop storage naming

---------

Co-authored-by: Skeletor Spaceman <skeletorspaceman@gmail.com>
@mslipper mslipper requested review from a team as code owners February 6, 2025 00:50
@mslipper mslipper changed the base branch from develop to feat/interop-stable-devnet February 6, 2025 00:50
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 84.29752% with 19 lines in your changes missing coverage. Please review.

Project coverage is 94.11%. Comparing base (db62b8f) to head (4a318ed).
Report is 1 commits behind head on feat/interop-stable-devnet.

Files with missing lines Patch % Lines
...ges/contracts-bedrock/src/L2/DependencyManager.sol 0.00% 12 Missing ⚠️
...ackages/contracts-bedrock/src/L1/SharedLockbox.sol 88.88% 2 Missing ⚠️
...ages/contracts-bedrock/src/L1/SuperchainConfig.sol 50.00% 2 Missing ⚠️
...ntracts-bedrock/src/L1/SuperchainConfigInterop.sol 95.00% 2 Missing ⚠️
...ckages/contracts-bedrock/src/L2/L1BlockInterop.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           feat/interop-stable-devnet   #14199       +/-   ##
===============================================================
+ Coverage                       46.46%   94.11%   +47.64%     
===============================================================
  Files                             997      109      -888     
  Lines                           84494     4688    -79806     
===============================================================
- Hits                            39264     4412    -34852     
+ Misses                          42245      276    -41969     
+ Partials                         2985        0     -2985     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 94.11% <84.29%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...kages/contracts-bedrock/src/L1/OptimismPortal2.sol 98.21% <100.00%> (+0.15%) ⬆️
...contracts-bedrock/src/L1/OptimismPortalInterop.sol 100.00% <100.00%> (ø)
packages/contracts-bedrock/src/L2/CrossL2Inbox.sol 100.00% <ø> (+24.00%) ⬆️
...acts-bedrock/src/L2/L2ToL2CrossDomainMessenger.sol 100.00% <100.00%> (ø)
...ges/contracts-bedrock/src/libraries/Predeploys.sol 97.82% <100.00%> (+0.04%) ⬆️
...ackages/contracts-bedrock/src/universal/WETH98.sol 100.00% <ø> (ø)
...ckages/contracts-bedrock/src/L2/L1BlockInterop.sol 81.81% <0.00%> (-11.74%) ⬇️
...ackages/contracts-bedrock/src/L1/SharedLockbox.sol 88.88% <88.88%> (ø)
...ages/contracts-bedrock/src/L1/SuperchainConfig.sol 92.59% <50.00%> (-7.41%) ⬇️
...ntracts-bedrock/src/L1/SuperchainConfigInterop.sol 95.00% <95.00%> (ø)
... and 1 more

... and 890 files with indirect coverage changes

@mslipper mslipper merged commit 31a9c29 into feat/interop-stable-devnet Feb 6, 2025
@mslipper mslipper deleted the sc-feat/add-shared-lockbox branch February 6, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants